Fail build in PR check when UT fail #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yaqiangz
force-pushed
the
master_fail_build
branch
from
32d1477 to
af53b5b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @yxieca could you please help to review this PR? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Blueve
approved these changes
Dec 25, 2024
yaqiangz
added a commit
to yaqiangz/sonic-dhcp-relay
that referenced
this pull request
Dec 30, 2024
This reverts commit dbaee8b.
yaqiangz
added a commit
that referenced
this pull request
Dec 30, 2024
Why I did it In previous PR #53, we fail build when UT fail, it works well in current repo. But UT in sonic-buildimage failed due to redis issue in slave container, which would block submodule update image How I did it Revert previous PR to don't fail build when UT fail for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
In current PR check, we would build dhcp6relay debian package, but even if the unit test failed, the build would still be ongoing, then the PR check would pass. It would cause we miss some unexpected damage change
How I did it
Modify Makefile to exit with code 1 if test fail
How I verify it
PR check